FINERACT-2480: Remove AppUserClientMapping entity (Phase 1 of self-service removal)#5498
Open
AshharAhmadKhan wants to merge 1 commit intoapache:developfrom
Open
Conversation
IOhacker
requested changes
Feb 15, 2026
Contributor
IOhacker
left a comment
IOhacker
left a comment
There was a problem hiding this comment.
@AshharAhmadKhan I think that it should be a single PR, not in phases.
Author
|
Hi @IOhacker, Thank you for reviewing this and for the feedback. I structured the work in phases to keep each change small and easier to review, but I understand the preference for a single PR. I’m happy to align with whatever approach is preferred for the project. Would you recommend consolidating everything related to FINERACT-2480 into one PR, or keeping it as a single PR with logically separated commits for clarity? Please let me know the preferred direction and I’ll adjust accordingly. Thanks again for your guidance. |
Contributor
|
Hello,
I would go for consolidating everything in one single commit/PR
Best regards
Victor
El dom, 15 feb 2026 a las 1:27, Ashhar Ahmad Khan ***@***.***>)
escribió:
… *AshharAhmadKhan* left a comment (apache/fineract#5498)
<#5498 (comment)>
Hi @IOhacker <https://github.com/IOhacker>,
Thank you for reviewing this and for the feedback.
I structured the work in phases to keep each change small and easier to
review, but I understand the preference for a single PR. I’m happy to align
with whatever approach is preferred for the project.
Would you recommend consolidating everything related to FINERACT-2480
<https://issues.apache.org/jira/browse/FINERACT-2480> into one PR, or
keeping it as a single PR with logically separated commits for clarity?
Please let me know the preferred direction and I’ll adjust accordingly.
Thanks again for your guidance.
—
Reply to this email directly, view it on GitHub
<#5498 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALD2ZAWPZNJWZHW2NOWVOPT4MANUZAVCNFSM6AAAAACVFPOEUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMBTGUZTMMBVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR is Phase 1 of removing the insecure self-service feature as requested in FINERACT-2480.
What This PR Does:
AppUserClientMappingentity classAppUserClientMappingfromAppUserdomain classScope:
Phase 1 focuses on entity-level cleanup. Subsequent phases will remove:
Changes:
AppUserClientMapping.java(88 lines)AppUser.java(removed 28 lines)Testing:
CI will run full test suite to verify no regressions.
Related: